this time hopefully with whitespace errors fixed $ git am --whitespace=fix megapile_8/* Applying: ffmpeg 4.4 bluray lpcm encoder Applying: Fix ffmpeg 4.4 bluray lpcm patch for 5.1 ? Applying: Add simple m2ts lpcm profile Applying: Improve truehd decoder/encoder from ffmpeg.git Applying: EXPERIMENT: update bdwrite for lpcm/hevc Applying: EXPERIMENTAL: add variable chapter interval to bdwrite Applying: EXPERIMENTAL: add bd_profile array to bdcreate.C (so in future we can diff between encoders) Applying: EXPERIMENTAL: bdcreate: add m2ts profiles, part 1 Applying: Fix bdcreate.C layout Applying: EXPERIMENTAL: attempt to get value from popuptextbox Applying: Rename m2ts_pcm.m2ts to bluray_lpcm.m2ts Applying: truehd experimental bluray profile Applying: EXPERIMENTAL: add truehd audio profile for bdcreate.C Applying: EXPERIMENTAL: add tsmuxer checkbox Applying: EXPERIMENTAL: fix layout in bdcreate after tsmuxer checkbox Applying: NOT YET Applying: EXPERIMENTAL: shell script run tsmuxer conditionally on bd.meta, bd.meta conditionally written on gui var Applying: Attempt at fixing bdwrite (stream_type/coding_type confusion) Applying: EXPERIMENTAL: attempt at fixing bdwrite on Android after my changes, still crash Applying: EXPERIMENTAL: real fix for bdwrite? Applying: EXPERIMENTAL: try to add lpcm to tsmuxer meta file Applying: EXPERIMENTAL: really fix audio names fir tsmuxer meta? Applying: mem and resource leaks in indexfile/indextate (cppcheck) Applying: cppcheck in cursor.C Applying: cppcheck in resourcepixmap.C Applying: Add objrem target for thirdparty/Makefile, removes only .o objs Applying: Freebsd 13 conditional include in exportedl.C Applying: fileexr forward port (openexr 3) Applying: filegif addition of nearly all quntize.c from giflib dist, needed on freebsd/external giflib > 5.1.9 Applying: unsigned long cast for freebsd in bctrace.C Applying: dirent64 and readdir64 aliases for freebsd in guicast/filesystem.h Applying: realtime prio only on linux and termux for now Applying: freebsd includes in plugins/titler Applying: freebsd defines in guicast/bcresources.C Applying: freebsd in indexfile.C Applying: freebsd in file.C Applying: freebsd in bdcreate/bdwrite Applying: freebsd in dvdcreate.C Applying: pkg-config based dynamic openexr link fix for freebsdv13 Applying: disable frei0r and libvmaf for freebsd 13/dynamic ffmpeg Applying: update blds/bsd.bld for freebsd 13 Applying: Attempt at adding freebsd detect in plugins/Makefile Applying: Attempt at freebsd/netbsd detection in cinelerra/Makefile Applying: experimental: switch python in guicast to python3 unconditionally Applying: Add android-only hacked Dynamic makefile libs Applying: Make cin compile with ffmpeg 5 (unconditionally) Applying: Dynamic termux configure Applying: Hopefully fixed dynamic liba52 Applying: Cinelerra/Makefile dynamic section fix for non-android, i hope Applying: Hopefully fix dyn liba52 on termux Applying: Dynamic termux + libzmpeg Applying: Patches for attempting to make netbsd/i386 compile Applying: video4linux2 and DVB support currently depend on libzmpeg Applying: Try to abort earlier if xinerama/xfixes support not here Applying: Beginning of ffmpeg versioned compilation Applying: Ffmpeg versioning in bdwrite.C Applying: More libavcodec versionkng in ffmpeg Applying: Even more ffmpeg versioning in ffmpeg.C Applying: Nearly all versioning in ffmpeg.C Applying: Finished versioning in ffmpeg.C Applying: Really fix ffmpeg.C for ffmpeg 4.4 Applying: ffmpeg.git conditional fixes Applying: Limit git clone depth to 1 (faster download, less space) Applying: More defines in ffmpeg.h Applying: openexr dynamic libs in termux_dyn Applying: Even more ffmpeg version ifdefs in ffmpeg.C Applying: Hopefully fix 'or' conditional in cinelerra/Makefile Applying: Hopefully fix dynamic openexr via pkg-config in configure.ac Applying: Abort earlier if non-3rd party and openexr requested but not found Applying: update termux_dyn, now detection of openexr moved to configure.ac Applying: Add /usr/include/a52dec so libzmpeg3 can be compiled on Linux dynamically Applying: HIGHLY EXPERIMENTAL: constify png_data Applying: Defend against missed lv2 headers Applying: Fix for dynamic libogg Applying: Dynamic termux with ogg Applying: Attempt at detecting OpenEXR 3 $ cp -ar megapile_8 ~/storage/downloads/ $ tar -cvzf megapile_8.tar.gz megapile_8/ megapile_8/ megapile_8/0001-ffmpeg-4.4-bluray-lpcm-encoder.patch megapile_8/0002-Fix-ffmpeg-4.4-bluray-lpcm-patch-for-5.1.patch megapile_8/0003-Add-simple-m2ts-lpcm-profile.patch megapile_8/0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch megapile_8/0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch megapile_8/0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch megapile_8/0007-EXPERIMENTAL-add-bd_profile-array-to-bdcreate.C-so-i.patch megapile_8/0008-EXPERIMENTAL-bdcreate-add-m2ts-profiles-part-1.patch megapile_8/0009-Fix-bdcreate.C-layout.patch megapile_8/0010-EXPERIMENTAL-attempt-to-get-value-from-popuptextbox.patch megapile_8/0011-Rename-m2ts_pcm.m2ts-to-bluray_lpcm.m2ts.patch megapile_8/0012-truehd-experimental-bluray-profile.patch megapile_8/0013-EXPERIMENTAL-add-truehd-audio-profile-for-bdcreate.C.patch megapile_8/0014-EXPERIMENTAL-add-tsmuxer-checkbox.patch megapile_8/0015-EXPERIMENTAL-fix-layout-in-bdcreate-after-tsmuxer-ch.patch megapile_8/0016-NOT-YET.patch megapile_8/0017-EXPERIMENTAL-shell-script-run-tsmuxer-conditionally-.patch megapile_8/0018-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch megapile_8/0019-EXPERIMENTAL-attempt-at-fixing-bdwrite-on-Android-af.patch megapile_8/0020-EXPERIMENTAL-real-fix-for-bdwrite.patch megapile_8/0021-EXPERIMENTAL-try-to-add-lpcm-to-tsmuxer-meta-file.patch megapile_8/0022-EXPERIMENTAL-really-fix-audio-names-fir-tsmuxer-meta.patch === blu-ray part end === megapile_8/0023-mem-and-resource-leaks-in-indexfile-indextate-cppche.patch megapile_8/0024-cppcheck-in-cursor.C.patch megapile_8/0025-cppcheck-in-resourcepixmap.C.patch === cppcheck (old) end === megapile_8/0026-Add-objrem-target-for-thirdparty-Makefile-removes-on.patch === personal space saver on termux end === megapile_8/0027-Freebsd-13-conditional-include-in-exportedl.C.patch megapile_8/0028-fileexr-forward-port-openexr-3.patch megapile_8/0029-filegif-addition-of-nearly-all-quntize.c-from-giflib.patch 0029 a bit questionable - should I leave it as-is or split into another file? IMO CIinelerra adds stuff into one file... megapile_8/0030-unsigned-long-cast-for-freebsd-in-bctrace.C.patch megapile_8/0033-freebsd-includes-in-plugins-titler.patch megapile_8/0031-dirent64-and-readdir64-aliases-for-freebsd-in-guicas.patch megapile_8/0032-realtime-prio-only-on-linux-and-termux-for-now.patch megapile_8/0034-freebsd-defines-in-guicast-bcresources.C.patch megapile_8/0035-freebsd-in-indexfile.C.patch megapile_8/0036-freebsd-in-file.C.patch megapile_8/0037-freebsd-in-bdcreate-bdwrite.patch megapile_8/0038-freebsd-in-dvdcreate.C.patch megapile_8/0039-pkg-config-based-dynamic-openexr-link-fix-for-freebs.patch megapile_8/0040-disable-frei0r-and-libvmaf-for-freebsd-13-dynamic-ff.patch megapile_8/0041-update-blds-bsd.bld-for-freebsd-13.patch megapile_8/0042-Attempt-at-adding-freebsd-detect-in-plugins-Makefile.patch megapile_8/0043-Attempt-at-freebsd-netbsd-detection-in-cinelerra-Mak.patch === most of freebsd series, but see later=== megapile_8/0044-experimental-switch-python-in-guicast-to-python3-unc.patch ==== I think I'll rework this for conditionally call python3 on netbsd only or may be detect python binary at configure time === megapile_8/0045-Add-android-only-hacked-Dynamic-makefile-libs.patch megapile_8/0046-Make-cin-compile-with-ffmpeg-5-unconditionally.patch megapile_8/0047-Dynamic-termux-configure.patch megapile_8/0048-Hopefully-fixed-dynamic-liba52.patch megapile_8/0049-Cinelerra-Makefile-dynamic-section-fix-for-non-andro.patch megapile_8/0050-Hopefully-fix-dyn-liba52-on-termux.patch megapile_8/0051-Dynamic-termux-libzmpeg.patch megapile_8/0052-Patches-for-attempting-to-make-netbsd-i386-compile.patch megapile_8/0053-video4linux2-and-DVB-support-currently-depend-on-lib.patch megapile_8/0054-Try-to-abort-earlier-if-xinerama-xfixes-support-not-.patch megapile_8/0055-Beginning-of-ffmpeg-versioned-compilation.patch megapile_8/0056-Ffmpeg-versioning-in-bdwrite.C.patch megapile_8/0057-More-libavcodec-versionkng-in-ffmpeg.patch megapile_8/0058-Even-more-ffmpeg-versioning-in-ffmpeg.C.patch megapile_8/0059-Nearly-all-versioning-in-ffmpeg.C.patch megapile_8/0060-Finished-versioning-in-ffmpeg.C.patch megapile_8/0061-Really-fix-ffmpeg.C-for-ffmpeg-4.4.patch megapile_8/0062-ffmpeg.git-conditional-fixes.patch megapile_8/0063-Limit-git-clone-depth-to-1-faster-download-less-spac.patch megapile_8/0064-More-defines-in-ffmpeg.h.patch megapile_8/0068-Hopefully-fix-dynamic-openexr-via-pkg-config-in-conf.patch megapile_8/0070-update-termux_dyn-now-detection-of-openexr-moved-to-.patch megapile_8/0071-Add-usr-include-a52dec-so-libzmpeg3-can-be-compiled-.patch megapile_8/0074-Fix-for-dynamic-libogg.patch megapile_8/0076-Attempt-at-detecting-OpenEXR-3.patch megapile_8/0065-openexr-dynamic-libs-in-termux_dyn.patch megapile_8/0066-Even-more-ffmpeg-version-ifdefs-in-ffmpeg.C.patch == dynamic compilation/fortifying configure/ffmpeg 4 +5 === megapile_8/0067-Hopefully-fix-or-conditional-in-cinelerra-Makefile.patch === 'OR' in Makefile a bit hard, picked answer from stackoverflow, not tested on BSD yet === megapile_8/0069-Abort-earlier-if-non-3rd-party-and-openexr-requested.patch megapile_8/0072-HIGHLY-EXPERIMENTAL-constify-png_data.patch megapile_8/0073-Defend-against-missed-lv2-headers.patch megapile_8/0075-Dynamic-termux-with-ogg.patch ==latest attempts at fixing openexr3 confiigure check and libogg / libvorbis secret libs ===
Normal build with thirdparty works without problems. Using --without-thirdparty, there is an initial configure error that says it can't find the lv2-headers (in my arch it seems that lv2-headers are included in the lv2 package; I couldn't find any other reference). So I used both --without-thirdparty and --without-lv2. The build fails; I attach cin5.log and config.log PS: I applied the patches without the need of --ignore-whitespace; it works fine, thanks.
On Tuesday, April 12, 2022, Andrea paz <gamberucci.andrea@gmail.com> wrote:
Normal build with thirdparty works without problems. Using --without-thirdparty, there is an initial configure error that says it can't find the lv2-headers (in my arch it seems that lv2-headers are included in the lv2 package; I couldn't find any other reference). So I used both --without-thirdparty and --without-lv2. The build fails; I attach cin5.log and config.log
g++ `cat x86_64/c_flags` -DMSGQUAL=fileffmpeg -c fileffmpeg.C -o x86_6 g++ `cat x86_64/c_flags` -DMSGQUAL=fileflac -c fileflac.C -o x86_64/fi g++ `cat x86_64/c_flags` -DMSGQUAL=fileformat -c fileformat.C -o x86_6 In file included from filedpx.C:25: filedpx.h:29:10: fatal error: DPX.h: File o directory non esistente 29 | #include "DPX.h" | ^~~~~~~ compilation terminated. make[2]: *** [Makefile:585: x86_64/filedpx.o] Errore 1 still need to abort on missing libdpx + no-thirdparty.... disable it please for now)
PS: I applied the patches without the need of --ignore-whitespace; it works fine, thanks.
also, does this patch fix lv2 detection? --- a/cinelerra-5.1/configure.ac +++ b/cinelerra-5.1/configure.ac @@ -801,10 +801,10 @@ CHECK_WANT([LV2], [auto], [use lv2], [ CHECK_LIB([sord], [sord-0], [sord_world_new]) CHECK_LIB([serd], [serd-0], [serd_reader_new]) CHECK_LIB([sratom], [sratom-0], [sratom_new]) - CFLAGS="-I/usr/include/lilv-0 -I/usr/local/include/lilv-0" + CFLAGS="-I/usr/include/lilv-0 -I/usr/local/include/lilv-0 `pkg-config --cflags lilv-0`" CHECK_HEADERS([lv2], [lilv headers], [lilv/lilv.h]) CHECK_LIB([suil], [suil-0], [suil_instance_new]) - CFLAGS="-I/usr/include/suil-0 -I/usr/local/include/suil-0" + CFLAGS="-I/usr/include/suil-0 -I/usr/local/include/suil-0 `pkg-config --cflags suil-0`" CHECK_HEADERS([lv2], [suil headers], [suil/suil.h]) CFLAGS="$saved_CFLAGS"]) # have all or none $ ah.. basically add `pkg-config --cflags lilv-0` and same for suil-0 into relevant lines in configure.ac and autogen it again? On Tuesday, April 12, 2022, Andrew Randrianasulu <randrianasulu@gmail.com> wrote:
On Tuesday, April 12, 2022, Andrea paz <gamberucci.andrea@gmail.com> wrote:
Normal build with thirdparty works without problems. Using --without-thirdparty, there is an initial configure error that says it can't find the lv2-headers (in my arch it seems that lv2-headers are included in the lv2 package; I couldn't find any other reference). So I used both --without-thirdparty and --without-lv2. The build fails; I attach cin5.log and config.log
g++ `cat x86_64/c_flags` -DMSGQUAL=fileffmpeg -c fileffmpeg.C -o x86_6 g++ `cat x86_64/c_flags` -DMSGQUAL=fileflac -c fileflac.C -o x86_64/fi g++ `cat x86_64/c_flags` -DMSGQUAL=fileformat -c fileformat.C -o x86_6 In file included from filedpx.C:25: filedpx.h:29:10: fatal error: DPX.h: File o directory non esistente 29 | #include "DPX.h" | ^~~~~~~ compilation terminated. make[2]: *** [Makefile:585: x86_64/filedpx.o] Errore 1
still need to abort on missing libdpx + no-thirdparty.... disable it please for now)
PS: I applied the patches without the need of --ignore-whitespace; it works fine, thanks.
I remade the build with --without-(libdpx thirdparty lv2). I removed ache lv2 because I can't apply the patch you posted in the body of the email. It gives me this error: error: frammento di patch senza intestazione alla riga 3: @@ -801,10 +801,10 @@ CHECK_WANT([LV2], [auto], [use lv2], [Patch non riuscita a 0077 The compilation did not give any errors (only error with DV that did not compromise the compile), but it lasted very little compared to normal. However CinGG doesn't start because it's missing .../bin/cin $ CIN_CONFIG=/home/paz/.bcast6 /home/paz/cinelerra5/cinelerra-5.1/bin/./cin bash: /home/paz/cinelerra5/cinelerra-5.1/bin/./cin: File o directory non esistente I post the list of the contents of .../bin: $ ls -l totale 25116 -rw-r--r-- 1 paz wheel 18092 12 apr 12.06 COPYING -rw-r--r-- 1 paz wheel 9114 12 apr 12.06 Cinelerra_factory -rw-r--r-- 1 paz wheel 1845 12 apr 12.06 README drwxr-xr-x 2 paz wheel 25 12 apr 12.09 applications -rwxr-xr-x 1 paz wheel 72288 12 apr 12.09 bdwrite drwxr-xr-x 2 paz wheel 4096 12 apr 12.09 doc -rw-r--r-- 1 paz wheel 3956 12 apr 12.06 expanders.es -rw-r--r-- 1 paz wheel 3991 12 apr 12.06 expanders.fr -rw-r--r-- 1 paz wheel 4178 12 apr 12.06 expanders.txt drwxr-xr-x 5 paz wheel 137 12 apr 12.07 ffmpeg -rwxr-xr-x 1 paz wheel 460184 12 apr 12.09 hveg2enc drwxr-xr-x 2 paz wheel 25 12 apr 12.06 info drwxr-xr-x 19 paz wheel 176 12 apr 12.09 locale drwxr-xr-x 2 paz wheel 6 12 apr 12.09 lv2 -rw-r--r-- 1 paz wheel 3715 12 apr 12.06 lv2_blacklist.txt drwxr-xr-x 2 paz wheel 4096 12 apr 12.06 models -rwxr-xr-x 1 paz wheel 4224712 12 apr 12.09 mplexlo drwxr-xr-x 2 paz wheel 17 12 apr 12.06 msg drwxr-xr-x 2 paz wheel 36 12 apr 12.09 pixmaps drwxr-xr-x 3 paz wheel 19 12 apr 12.09 plugins -rw-r--r-- 1 paz wheel 3145 12 apr 12.06 shuttlerc drwxr-xr-x 2 paz wheel 4096 12 apr 12.06 tips -rwxr-xr-x 1 paz wheel 4221696 12 apr 12.09 zmpeg3cat -rwxr-xr-x 1 paz wheel 4225600 12 apr 12.09 zmpeg3cc2txt -rwxr-xr-x 1 paz wheel 4109288 12 apr 12.09 zmpeg3ifochk -rwxr-xr-x 1 paz wheel 4104816 12 apr 12.09 zmpeg3show -rwxr-xr-x 1 paz wheel 4209560 12 apr 12.09 zmpeg3toc
try to step into cinelerra and run make from there... i guess I missed some libs... On Tuesday, April 12, 2022, Andrea paz <gamberucci.andrea@gmail.com> wrote:
I remade the build with --without-(libdpx thirdparty lv2). I removed ache lv2 because I can't apply the patch you posted in the body of the email. It gives me this error:
error: frammento di patch senza intestazione alla riga 3: @@ -801,10 +801,10 @@ CHECK_WANT([LV2], [auto], [use lv2], [Patch non riuscita a 0077
The compilation did not give any errors (only error with DV that did not compromise the compile), but it lasted very little compared to normal. However CinGG doesn't start because it's missing .../bin/cin
$ CIN_CONFIG=/home/paz/.bcast6 /home/paz/cinelerra5/ cinelerra-5.1/bin/./cin bash: /home/paz/cinelerra5/cinelerra-5.1/bin/./cin: File o directory non esistente
I post the list of the contents of .../bin:
$ ls -l totale 25116 -rw-r--r-- 1 paz wheel 18092 12 apr 12.06 COPYING -rw-r--r-- 1 paz wheel 9114 12 apr 12.06 Cinelerra_factory -rw-r--r-- 1 paz wheel 1845 12 apr 12.06 README drwxr-xr-x 2 paz wheel 25 12 apr 12.09 applications -rwxr-xr-x 1 paz wheel 72288 12 apr 12.09 bdwrite drwxr-xr-x 2 paz wheel 4096 12 apr 12.09 doc -rw-r--r-- 1 paz wheel 3956 12 apr 12.06 expanders.es -rw-r--r-- 1 paz wheel 3991 12 apr 12.06 expanders.fr -rw-r--r-- 1 paz wheel 4178 12 apr 12.06 expanders.txt drwxr-xr-x 5 paz wheel 137 12 apr 12.07 ffmpeg -rwxr-xr-x 1 paz wheel 460184 12 apr 12.09 hveg2enc drwxr-xr-x 2 paz wheel 25 12 apr 12.06 info drwxr-xr-x 19 paz wheel 176 12 apr 12.09 locale drwxr-xr-x 2 paz wheel 6 12 apr 12.09 lv2 -rw-r--r-- 1 paz wheel 3715 12 apr 12.06 lv2_blacklist.txt drwxr-xr-x 2 paz wheel 4096 12 apr 12.06 models -rwxr-xr-x 1 paz wheel 4224712 12 apr 12.09 mplexlo drwxr-xr-x 2 paz wheel 17 12 apr 12.06 msg drwxr-xr-x 2 paz wheel 36 12 apr 12.09 pixmaps drwxr-xr-x 3 paz wheel 19 12 apr 12.09 plugins -rw-r--r-- 1 paz wheel 3145 12 apr 12.06 shuttlerc drwxr-xr-x 2 paz wheel 4096 12 apr 12.06 tips -rwxr-xr-x 1 paz wheel 4221696 12 apr 12.09 zmpeg3cat -rwxr-xr-x 1 paz wheel 4225600 12 apr 12.09 zmpeg3cc2txt -rwxr-xr-x 1 paz wheel 4109288 12 apr 12.09 zmpeg3ifochk -rwxr-xr-x 1 paz wheel 4104816 12 apr 12.09 zmpeg3show -rwxr-xr-x 1 paz wheel 4209560 12 apr 12.09 zmpeg3toc
Andrew, I am working on megapile_8 today (that is a fun name).
$ git am --whitespace=fix megapile_8/*
Question? we already decided on blds/termux.bld and added that awhile back. So now why abandon that and add "termux_dyn.sh" instead as in patch: 0047-Dynamic-termux-configure.patch ??
On Tuesday, April 12, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, I am working on megapile_8 today (that is a fun name).
$ git am --whitespace=fix megapile_8/*
Question? we already decided on blds/termux.bld and added that awhile back. So now why abandon that and add "termux_dyn.sh" instead as in patch: 0047-Dynamic-termux-configure.patch ??
not instead, they build different versions (dynamic build not fully ready - I plan to extract libbthread from thirdparty into same level along with libzmpeg and co, so dynamc build will be automatic. (right now it uses manually compiled and placed libbthread.a as jpt.a)) PS: at least freebsd 13 comes with vaapi/vdpau libs by default, so I deleted disabling them switches from blds/bsd.bld and rebuild with success. no way to test this kind of accel in VM {OpenGL works with llvmpipe} ... also, lv2 appear to work (when used as shared library from system). May be we can differenciate between freebsd 13+ build and earlier freebsds by making their own build scripts separate? Or made one script handle version parameter, like main bld script does for various linuxes...
Thanks for the explanation. So is it OK to put this new one in the blds subdirectory instead so that it is in the same place as all of the other non-default builds? and so the main directory is not overly cluttered? On Tue, Apr 12, 2022 at 2:02 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
On Tuesday, April 12, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, I am working on megapile_8 today (that is a fun name).
$ git am --whitespace=fix megapile_8/*
Question? we already decided on blds/termux.bld and added that awhile back. So now why abandon that and add "termux_dyn.sh" instead as in patch: 0047-Dynamic-termux-configure.patch ??
not instead, they build different versions (dynamic build not fully ready - I plan to extract libbthread from thirdparty into same level along with libzmpeg and co, so dynamc build will be automatic. (right now it uses manually compiled and placed libbthread.a as jpt.a))
PS: at least freebsd 13 comes with vaapi/vdpau libs by default, so I deleted disabling them switches from blds/bsd.bld and rebuild with success. no way to test this kind of accel in VM {OpenGL works with llvmpipe} ... also, lv2 appear to work (when used as shared library from system). May be we can differenciate between freebsd 13+ build and earlier freebsds by making their own build scripts separate? Or made one script handle version parameter, like main bld script does for various linuxes...
On Tuesday, April 12, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Thanks for the explanation. So is it OK to put this new one in the blds subdirectory instead so that it is in the same place as all of the other non-default builds? and so the main directory is not overly cluttered?
surely!
On Tue, Apr 12, 2022 at 2:02 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
On Tuesday, April 12, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, I am working on megapile_8 today (that is a fun name).
$ git am --whitespace=fix megapile_8/*
Question? we already decided on blds/termux.bld and added that awhile back. So now why abandon that and add "termux_dyn.sh" instead as in patch: 0047-Dynamic-termux-configure.patch ??
not instead, they build different versions (dynamic build not fully ready - I plan to extract libbthread from thirdparty into same level along with libzmpeg and co, so dynamc build will be automatic. (right now it uses manually compiled and placed libbthread.a as jpt.a))
PS: at least freebsd 13 comes with vaapi/vdpau libs by default, so I deleted disabling them switches from blds/bsd.bld and rebuild with success. no way to test this kind of accel in VM {OpenGL works with llvmpipe} ... also, lv2 appear to work (when used as shared library from system). May be we can differenciate between freebsd 13+ build and earlier freebsds by making their own build scripts separate? Or made one script handle version parameter, like main bld script does for various linuxes...
Tested and checked into GIT the following from the MEGApile: 0001, 0002, 0003, 0011, 0032 $ git am --whitespace=fix megapile_8/*
Applying: ffmpeg 4.4 bluray lpcm encoder Applying: Fix ffmpeg 4.4 bluray lpcm patch for 5.1 ? Applying: Add simple m2ts lpcm profile
...
Applying: Rename m2ts_pcm.m2ts to bluray_lpcm.m2ts
...
Applying: realtime prio only on linux and termux for now
thanks! for further testing - right now my bd creation window look like this (attached) not very aligned.. I'll try to fix this but layout rules for various gui elements still not clear for me, any help? On Wednesday, April 13, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Tested and checked into GIT the following from the MEGApile: 0001, 0002, 0003, 0011, 0032
$ git am --whitespace=fix megapile_8/*
Applying: ffmpeg 4.4 bluray lpcm encoder Applying: Fix ffmpeg 4.4 bluray lpcm patch for 5.1 ? Applying: Add simple m2ts lpcm profile
...
Applying: Rename m2ts_pcm.m2ts to bluray_lpcm.m2ts
...
Applying: realtime prio only on linux and termux for now
Not sure what you want to change but making the box a little higher so that the green + and red x are lower can be done by changing the yS(290) to a larger number than 290 (what is currently line 481) as shown below in bdcreate.C option_presets(); int scr_x = mwindow->gui->get_screen_x(0, -1); int scr_w = mwindow->gui->get_screen_w(0, -1); int scr_h = mwindow->gui->get_screen_h(0, -1); int w = xS(560), *h = yS(290)*; int x = scr_x + scr_w/2 - w/2, y = scr_h/2 - h/2; The new "Profile" box looks OK. Did you want to change the placement of "use tsmuxer"? On Tue, Apr 12, 2022 at 5:42 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
thanks!
for further testing - right now my bd creation window look like this (attached)
not very aligned.. I'll try to fix this but layout rules for various gui elements still not clear for me, any help?
On Wednesday, April 13, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Tested and checked into GIT the following from the MEGApile: 0001, 0002, 0003, 0011, 0032
$ git am --whitespace=fix megapile_8/*
Applying: ffmpeg 4.4 bluray lpcm encoder Applying: Fix ffmpeg 4.4 bluray lpcm patch for 5.1 ? Applying: Add simple m2ts lpcm profile
...
Applying: Rename m2ts_pcm.m2ts to bluray_lpcm.m2ts
...
Applying: realtime prio only on linux and termux for now
On Wednesday, April 13, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Not sure what you want to change but making the box a little higher so that the green + and red x are lower can be done by changing the yS(290) to a larger number than 290 (what is currently line 481) as shown below in bdcreate.C
tbanks!
option_presets(); int scr_x = mwindow->gui->get_screen_x(0, -1); int scr_w = mwindow->gui->get_screen_w(0, -1); int scr_h = mwindow->gui->get_screen_h(0, -1); int w = xS(560), *h = yS(290)*; int x = scr_x + scr_w/2 - w/2, y = scr_h/2 - h/2;
The new "Profile" box looks OK. Did you want to change the placement of "use tsmuxer"?
no, just move ok/cancel buttons a bit down relative to others... and may be make nice rows out of usual checkboxes
On Tue, Apr 12, 2022 at 5:42 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
thanks!
for further testing - right now my bd creation window look like this (attached)
not very aligned.. I'll try to fix this but layout rules for various gui elements still not clear for me, any help?
On Wednesday, April 13, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Tested and checked into GIT the following from the MEGApile: 0001, 0002, 0003, 0011, 0032
$ git am --whitespace=fix megapile_8/*
Applying: ffmpeg 4.4 bluray lpcm encoder Applying: Fix ffmpeg 4.4 bluray lpcm patch for 5.1 ? Applying: Add simple m2ts lpcm profile
...
Applying: Rename m2ts_pcm.m2ts to bluray_lpcm.m2ts
...
Applying: realtime prio only on linux and termux for now
new, updated series! I moved libbthread at main level so dynamic termux build can be compiled automatically like others. not yet done any additional layout in bdcreate.C On Wednesday, April 13, 2022, Andrew Randrianasulu <randrianasulu@gmail.com> wrote:
On Wednesday, April 13, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Not sure what you want to change but making the box a little higher so that the green + and red x are lower can be done by changing the yS(290) to a larger number than 290 (what is currently line 481) as shown below in bdcreate.C
tbanks!
option_presets(); int scr_x = mwindow->gui->get_screen_x(0, -1); int scr_w = mwindow->gui->get_screen_w(0, -1); int scr_h = mwindow->gui->get_screen_h(0, -1); int w = xS(560), *h = yS(290)*; int x = scr_x + scr_w/2 - w/2, y = scr_h/2 - h/2;
The new "Profile" box looks OK. Did you want to change the placement of "use tsmuxer"?
no, just move ok/cancel buttons a bit down relative to others... and may be make nice rows out of usual checkboxes
On Tue, Apr 12, 2022 at 5:42 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
thanks!
for further testing - right now my bd creation window look like this (attached)
not very aligned.. I'll try to fix this but layout rules for various gui elements still not clear for me, any help?
On Wednesday, April 13, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Tested and checked into GIT the following from the MEGApile: 0001, 0002, 0003, 0011, 0032
$ git am --whitespace=fix megapile_8/*
Applying: ffmpeg 4.4 bluray lpcm encoder Applying: Fix ffmpeg 4.4 bluray lpcm patch for 5.1 ? Applying: Add simple m2ts lpcm profile
...
Applying: Rename m2ts_pcm.m2ts to bluray_lpcm.m2ts
...
Applying: realtime prio only on linux and termux for now
does this patch (on top of megapile_9) help? On Wednesday, April 13, 2022, Andrew Randrianasulu <randrianasulu@gmail.com> wrote:
thanks, it was not supposed to build this lib on non-android.... (
On Wednesday, April 13, 2022, Andrea paz <gamberucci.andrea@gmail.com> wrote:
Still crashing with megapile_9, I enclose cin5.log and config.log
actually if this patch will not help try also second on top of all this - I renamed source file (so clang stopped complaining) and deleted all those licence texts from middle of file (due to auto-cat-ing sources earlier. now I just compile single file into single o/a file. still work on Termux here..) On Wednesday, April 13, 2022, Andrew Randrianasulu <randrianasulu@gmail.com> wrote:
does this patch (on top of megapile_9) help?
On Wednesday, April 13, 2022, Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
thanks, it was not supposed to build this lib on non-android.... (
On Wednesday, April 13, 2022, Andrea paz <gamberucci.andrea@gmail.com> wrote:
Still crashing with megapile_9, I enclose cin5.log and config.log
With only the first patch it did not compile; with also the second one the build was successful. But as yesterday you don't create .../bin/cin ==> you can't start CinGG. I attach the logs even if I don't know if they can be useful.
ah, libdv + firewire libs... you can try to disable them (without-dv, without-firewire), or pass '--disable-static-build' or add them to cinelerra/Makefile {i do not have them in termux, not sure if have any sense here.. no pci for external card, no iLink by design..} sorry, I meet those so many times I autocirrect for them by some hack without much thinking.... On Wednesday, April 13, 2022, Andrea paz <gamberucci.andrea@gmail.com> wrote:
With only the first patch it did not compile; with also the second one the build was successful. But as yesterday you don't create .../bin/cin ==> you can't start CinGG. I attach the logs even if I don't know if they can be useful.
Finally CinGG has started (without thirdparty). It's sure that it uses ffmpg5 of the istema because in startup it gives error on some new filters, as you had pointed out. Tomorrow I will test them one by one. Thanks Andrew; great job!
Andrea, good work and lots of it. Compiling can be a big battle, but correctly loading/playing/rendering for new and past projects is the ultimate test. On Wed, Apr 13, 2022 at 10:49 AM Andrea paz <gamberucci.andrea@gmail.com> wrote:
Finally CinGG has started (without thirdparty). It's sure that it uses ffmpg5 of the istema because in startup it gives error on some new filters, as you had pointed out. Tomorrow I will test them one by one. Thanks Andrew; great job!
Finally CinGG has started (without thirdparty). It's sure that it uses ffmpg5 of the system because in startup it gives error on some new filters, as you had pointed out. Tomorrow I will test them one by one. Thanks Andrew; great job!
should fix lv2 dynamic detection... On Wednesday, April 13, 2022, Andrea paz <gamberucci.andrea@gmail.com> wrote:
Finally CinGG has started (without thirdparty). It's sure that it uses ffmpg5 of the system because in startup it gives error on some new filters, as you had pointed out. Tomorrow I will test them one by one. Thanks Andrew; great job!
Andrew, I am still working with the megapile_8 so these number will be different than megapile_10. No problems adding 0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch but so far no gain in it. EXPERIMENT not ok 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch I was really hoping this would work as it would be a nice addition. There were multiple problems that I noted: - using the default chapter interval in the code, it created 4 chapters with the first 1 at 5 minutes, but BIg Buck Bunny is only 10:;34 long so there should only be at most 3 chapters. - when playing from the beginning after just sticking the disc in the player attached to the TV, it suddenly just stopped at about 7 minutes and then timed out and went back to the player beginning screen - if I start the disc again and then fast forward, it does weird stuff. It does seem to fast forward correctly and the info shows the timing correctly, but it looks like when it gets to about 7 minutes, it does not play Big Buck Bunny but goes beyond that and plays some leftover stuff from a previous disc write (it is a Rewritable Disc because I have to test over and over and over again when it comes to bluray). I did look at all other patches that affect bdwrite.C in megapile_8 but see none that could possibly fix the chapter interval. These are 0016, 0018, 0019, 0020, 0037, 0046, 0052, and 0056. Should I ignore all EXPERIMENTAL patches for bluray? Also, going in numerical order, I am assuming that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is no longer needed because the code will be included in ffmpeg 5.1? On Wed, Apr 13, 2022 at 11:47 AM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
should fix lv2 dynamic detection...
On Wednesday, April 13, 2022, Andrea paz <gamberucci.andrea@gmail.com> wrote:
Finally CinGG has started (without thirdparty). It's sure that it uses ffmpg5 of the system because in startup it gives error on some new filters, as you had pointed out. Tomorrow I will test them one by one. Thanks Andrew; great job!
On Wednesday, April 13, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, I am still working with the megapile_8 so these number will be different than megapile_10.
No problems adding 0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch but so far no gain in it. EXPERIMENT not ok 0006-EXPERIMENTAL-add-variable-chapter-interval-to- bdwrit.patch I was really hoping this would work as it would be a nice addition. There were multiple problems that I noted: - using the default chapter interval in the code, it created 4 chapters with the first 1 at 5 minutes, but BIg Buck Bunny is only 10:;34 long so there should only be at most 3 chapters. - when playing from the beginning after just sticking the disc in the player attached to the TV, it suddenly just stopped at about 7 minutes and then timed out and went back to the player beginning screen - if I start the disc again and then fast forward, it does weird stuff. It does seem to fast forward correctly and the info shows the timing correctly, but it looks like when it gets to about 7 minutes, it does not play Big Buck Bunny but goes beyond that and plays some leftover stuff from a previous disc write (it is a Rewritable Disc because I have to test over and over and over again when it comes to bluray).
I did look at all other patches that affect bdwrite.C in megapile_8 but see none that could possibly fix the chapter interval. These are 0016, 0018, 0019, 0020, 0037, 0046, 0052, and 0056. Should I ignore all EXPERIMENTAL patches for bluray?
well, other patches still add tsmuxer muxing and selectable audio codec - but if you have trouble playing disks created even with full patch set - set it aside... there are other areas to look at
Also, going in numerical order, I am assuming that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is no longer needed because the code will be included in ffmpeg 5.1?
well.. our internal ffmpeg still at 4.4. but your call - you can skip this for easier testing...
On Wed, Apr 13, 2022 at 11:47 AM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
should fix lv2 dynamic detection...
On Wednesday, April 13, 2022, Andrea paz <gamberucci.andrea@gmail.com> wrote:
Finally CinGG has started (without thirdparty). It's sure that it uses ffmpg5 of the system because in startup it gives error on some new filters, as you had pointed out. Tomorrow I will test them one by one. Thanks Andrew; great job!
Thanks, with megapile 10 I can use lv2. Il mer 13 apr 2022, 22:07 Andrew Randrianasulu <randrianasulu@gmail.com> ha scritto:
On Wednesday, April 13, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, I am still working with the megapile_8 so these number will be different than megapile_10.
No problems adding 0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch but so far no gain in it. EXPERIMENT not ok 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch I was really hoping this would work as it would be a nice addition. There were multiple problems that I noted: - using the default chapter interval in the code, it created 4 chapters with the first 1 at 5 minutes, but BIg Buck Bunny is only 10:;34 long so there should only be at most 3 chapters. - when playing from the beginning after just sticking the disc in the player attached to the TV, it suddenly just stopped at about 7 minutes and then timed out and went back to the player beginning screen - if I start the disc again and then fast forward, it does weird stuff. It does seem to fast forward correctly and the info shows the timing correctly, but it looks like when it gets to about 7 minutes, it does not play Big Buck Bunny but goes beyond that and plays some leftover stuff from a previous disc write (it is a Rewritable Disc because I have to test over and over and over again when it comes to bluray).
I did look at all other patches that affect bdwrite.C in megapile_8 but see none that could possibly fix the chapter interval. These are 0016, 0018, 0019, 0020, 0037, 0046, 0052, and 0056. Should I ignore all EXPERIMENTAL patches for bluray?
well, other patches still add tsmuxer muxing and selectable audio codec - but if you have trouble playing disks created even with full patch set - set it aside...
there are other areas to look at
Also, going in numerical order, I am assuming that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is no longer needed because the code will be included in ffmpeg 5.1?
well.. our internal ffmpeg still at 4.4. but your call - you can skip this for easier testing...
On Wed, Apr 13, 2022 at 11:47 AM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
should fix lv2 dynamic detection...
On Wednesday, April 13, 2022, Andrea paz <gamberucci.andrea@gmail.com> wrote:
Finally CinGG has started (without thirdparty). It's sure that it uses ffmpg5 of the system because in startup it gives error on some new filters, as you had pointed out. Tomorrow I will test them one by one. Thanks Andrew; great job!
Andrew, just an update only. I want to continue with the Bluray patches despite the problem with 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch which I had to back out. So I went forward with 0007-0017 which correctly patched but neither the choice of bluray_lpcm.m2ts or bluray_truehd.m2ts worked (got unknown bluray stream pcm_bluray and got unknown bluray audio format 0 ch). You may very well have fixed these in later patches but I am trying to go in order. Then as I patch 0018 and 0019, hunks fail because there is no "every_n_sec" from 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch was backed out. No need to reply -- I will continue to work around this and make changes manually so I can see if I can get the tsmuxer muxing and selectable audio codec working because they would be good additions. from a previous disc write (it is a Rewritable Disc because I have to test over and over and over again when it comes to bluray).
I did look at all other patches that affect bdwrite.C in megapile_8 but see none that could possibly fix the chapter interval. These are 0016, 0018, 0019, 0020, 0037, 0046, 0052, and 0056. Should I ignore all EXPERIMENTAL patches for bluray?
well, other patches still add tsmuxer muxing and selectable audio codec - but if you have trouble playing disks created even with full patch set - set it aside...
Andrew, another Bluray update.
From megapile_8, I have in the following Bluray patches with 2 modifications and the bluray disc works on both the Samsung UHD and the LG Bluray connected to the TV.
0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch0007-EXPERIMENTAL-add-bd_profile-array-to-bdcreate.C-so-i.patch 0008-EXPERIMENTAL-bdcreate-add-m2ts-profiles-part-1.patch 0009-Fix-bdcreate.C-layout.patch 0010-EXPERIMENTAL-attempt-to-get-value-from-popuptextbox.patch 0012-truehd-experimental-bluray-profile.patch 0013-EXPERIMENTAL-add-truehd-audio-profile-for-bdcreate.C.patch 0014-EXPERIMENTAL-add-tsmuxer-checkbox.patch 0015-EXPERIMENTAL-fix-layout-in-bdcreate-after-tsmuxer-ch.patch 0016-NOT-YET.patch 0017-EXPERIMENTAL-shell-script-run-tsmuxer-conditionally-.patch 0018-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch 0019-EXPERIMENTAL-attempt-at-fixing-bdwrite-on-Android-af.patch 0020-EXPERIMENTAL-real-fix-for-bdwrite.patch 0021-EXPERIMENTAL-try-to-add-lpcm-to-tsmuxer-meta-file.patch 0022-EXPERIMENTAL-really-fix-audio-names-fir-tsmuxer-meta.patch 0037-freebsd-in-bdcreate-bdwrite.patch (0001-0004 and 0011 were already checked into GIT) Unfortunately 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch causes problems BUT there are already chapters being written so I do not know why this was even added? and probably that is why it does not work. SEE ATTACHED for current TV shot of current bluray and note the Info stating chapters and they work when I skip forward or backward to the next or previous chapter. The 2 modifications I made are in bdcreate.C to temporarily comment out the choices of lpcm and truehd as neither 1 works for me (see error messages in previous email). However, the choice of "tsmuxer" works, or at least does something and creates no problem but I do not see or hear any difference if checked off or on. On Wed, Apr 13, 2022 at 6:42 PM Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, just an update only. I want to continue with the Bluray patches despite the problem with 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch which I had to back out. So I went forward with 0007-0017 which correctly patched but neither the choice of bluray_lpcm.m2ts or bluray_truehd.m2ts worked (got unknown bluray stream pcm_bluray and got unknown bluray audio format 0 ch). You may very well have fixed these in later patches but I am trying to go in order. Then as I patch 0018 and 0019, hunks fail because there is no "every_n_sec" from 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch was backed out.
No need to reply -- I will continue to work around this and make changes manually so I can see if I can get the tsmuxer muxing and selectable audio codec working because they would be good additions.
from a previous disc write (it is a Rewritable Disc because I have to test over and over and over again when it comes to bluray).
I did look at all other patches that affect bdwrite.C in megapile_8 but see none that could possibly fix the chapter interval. These are 0016, 0018, 0019, 0020, 0037, 0046, 0052, and 0056. Should I ignore all EXPERIMENTAL patches for bluray?
well, other patches still add tsmuxer muxing and selectable audio codec - but if you have trouble playing disks created even with full patch set - set it aside...
On Saturday, April 16, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, another Bluray update. From megapile_8, I have in the following Bluray patches with 2 modifications and the bluray disc works on both the Samsung UHD and the LG Bluray connected to the TV.
0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc. patch0007-EXPERIMENTAL-add-bd_profile-array-to-bdcreate.C-so-i.patch 0008-EXPERIMENTAL-bdcreate-add-m2ts-profiles-part-1.patch 0009-Fix-bdcreate.C-layout.patch 0010-EXPERIMENTAL-attempt-to-get-value-from-popuptextbox.patch 0012-truehd-experimental-bluray-profile.patch 0013-EXPERIMENTAL-add-truehd-audio-profile-for-bdcreate.C.patch 0014-EXPERIMENTAL-add-tsmuxer-checkbox.patch 0015-EXPERIMENTAL-fix-layout-in-bdcreate-after-tsmuxer-ch.patch 0016-NOT-YET.patch 0017-EXPERIMENTAL-shell-script-run-tsmuxer-conditionally-.patch 0018-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch 0019-EXPERIMENTAL-attempt-at-fixing-bdwrite-on-Android-af.patch 0020-EXPERIMENTAL-real-fix-for-bdwrite.patch 0021-EXPERIMENTAL-try-to-add-lpcm-to-tsmuxer-meta-file.patch 0022-EXPERIMENTAL-really-fix-audio-names-fir-tsmuxer-meta.patch 0037-freebsd-in-bdcreate-bdwrite.patch
(0001-0004 and 0011 were already checked into GIT)
Unfortunately 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch causes problems BUT there are already chapters being written so I do not know why this was even added?
may be I misread code, but I thought they were set at fixed 5 min intervals.. I thought making them at say 10 mins or even 15 mins from cmd line will be good idea.. apparently not (
and probably that is why it does not work. SEE ATTACHED for current TV shot of current bluray and note the Info stating chapters and they work when I skip forward or backward to the next or previous chapter.
The 2 modifications I made are in bdcreate.C to temporarily comment out the choices of lpcm and truehd as neither 1 works for me (see error messages in previous email).
those mesages come from players themselves? check if they actually support those - they are optional... However, the choice of "tsmuxer" works, or at least does something and
creates no problem but I do not see or hear any difference if checked off or on.
you need to have tsmuxer binary in $PATH to see it used
On Wed, Apr 13, 2022 at 6:42 PM Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, just an update only. I want to continue with the Bluray patches despite the problem with 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch which I had to back out. So I went forward with 0007-0017 which correctly patched but neither the choice of bluray_lpcm.m2ts or bluray_truehd.m2ts worked (got unknown bluray stream pcm_bluray and got unknown bluray audio format 0 ch). You may very well have fixed these in later patches but I am trying to go in order. Then as I patch 0018 and 0019, hunks fail because there is no "every_n_sec" from 0006-EXPERIMENTAL-add- variable-chapter-interval-to-bdwrit.patch was backed out.
No need to reply -- I will continue to work around this and make changes manually so I can see if I can get the tsmuxer muxing and selectable audio codec working because they would be good additions.
from a previous disc write (it is a Rewritable Disc because I have to test over and over and over again when it comes to bluray).
I did look at all other patches that affect bdwrite.C in megapile_8 but see none that could possibly fix the chapter interval. These are 0016, 0018, 0019, 0020, 0037, 0046, 0052, and 0056. Should I ignore all EXPERIMENTAL patches for bluray?
well, other patches still add tsmuxer muxing and selectable audio codec - but if you have trouble playing disks created even with full patch set - set it aside...
Andrew, The 2 modifications I made are in bdcreate.C to temporarily comment out the
choices of lpcm and truehd as neither 1 works for me (see error messages in previous email).
those mesages come from players themselves?
No, from bdwrite -- see the last line in the terminal output below for the error message when I choose "truehd" and then "lpcm". I verified that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is in as well as all of the patches as stated earlier. FFMPEG::open_decoder: some stream times estimated: /root/media/hockey.ts Render::render_single: Session finished. ** rendered 679 frames in 15.393 secs, 44.111 fps ++ dirname /tmp/bd_20220417-102756/bd.sh + sdir=/tmp/bd_20220417-102756 ++ cd /tmp/bd_20220417-102756 ++ pwd + dir=/tmp/bd_20220417-102756 + PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin + mkdir -p /tmp/bd_20220417-102756/udfs ++ tail -1 ++ du -cb /tmp/bd_20220417-102756/bd.m2ts ++ sed -e 's/[ ].*//' + sz=40396800 + blks=23821 + rm -f /tmp/bd_20220417-102756/bd.udfs + '[' -f bd.meta ']' + mkudffs -b 2048 /tmp/bd_20220417-102756/bd.udfs 23821 filename=/tmp/bd_20220417-102756/bd.udfs label=LinuxUDF uuid=625c4025cebbb06e blocksize=2048 blocks=23821 udfrev=2.01 start=0, blocks=16, type=ERASE start=16, blocks=4, type=VRS ... start=23648, blocks=16, type=RVDS start=23664, blocks=156, type=ERASE start=23820, blocks=1, type=ANCHOR + mount -t udf -o loop /tmp/bd_20220417-102756/bd.udfs /tmp/bd_20220417-102756/udfs + bdwrite /tmp/bd_20220417-102756/udfs /tmp/bd_20220417-102756/bd.m2ts *unknown bluray audio format 0 ch* FFMPEG::open_decoder: some stream times estimated: /root/media/hockey.ts Render::render_single: Session finished. ** rendered 679 frames in 15.329 secs, 44.295 fps ++ dirname /tmp/bd_20220417-105416/bd.sh + sdir=/tmp/bd_20220417-105416 ++ cd /tmp/bd_20220417-105416 ++ pwd + dir=/tmp/bd_20220417-105416 + PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin + mkdir -p /tmp/bd_20220417-105416/udfs ++ du -cb /tmp/bd_20220417-105416/bd.m2ts ++ tail -1 ++ sed -e 's/[ ].*//' + sz=44015616 + blks=25588 + rm -f /tmp/bd_20220417-105416/bd.udfs + '[' -f bd.meta ']' + mkudffs -b 2048 /tmp/bd_20220417-105416/bd.udfs 25588 filename=/tmp/bd_20220417-105416/bd.udfs label=LinuxUDF uuid=625c464fcd7855e8 blocksize=2048 blocks=25588 udfrev=2.01 start=0, blocks=16, type=ERASE start=16, blocks=4, type=VRS start=20, blocks=76, type=ERASE start=96, blocks=16, type=MVDS ... start=25587, blocks=1, type=ANCHOR + mount -t udf -o loop /tmp/bd_20220417-105416/bd.udfs /tmp/bd_20220417-105416/udfs + bdwrite /tmp/bd_20220417-105416/udfs /tmp/bd_20220417-105416/bd.m2ts *unknown bluray stream type pcm_bluray* may be I misread code, but I thought they were set at fixed 5 min
intervals.. I thought making them at say 10 mins or even 15 mins from cmd line will be good idea.. apparently not (
No, it is a good idea, that is why I keep testing it because for a 2 hour movie which I might put on bluray, every 5 minutes is overkill for a chapter. But I will take your advice and move on for now. The biggest problem with the chapter patch is that on the bluray attached to the TV, when you move to the back to the previous chapter, it acts like it moves back but plays where you already were instead. However, the choice of "tsmuxer" works, or at least does something and
creates no problem but I do not see or hear any difference if checked off or on.
you need to have tsmuxer binary in $PATH to see it used
I wonder why the output is different when I check the tsmuxer box than when I don't? I do not have tsmuxer binary in the $PATH and when I do "whereis tsmuxer", I get nothing so I do not think it is installed. Also, when I play each of the blurary with and without tsmuxer checked, I don't really notice a difference but I have bad eyes (and ears).
On Sunday, April 17, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew,
The 2 modifications I made are in bdcreate.C to temporarily comment out
the choices of lpcm and truehd as neither 1 works for me (see error messages in previous email).
those mesages come from players themselves?
No, from bdwrite -- see the last line in the terminal output below for the error message when I choose "truehd" and then "lpcm". I verified that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is in as well as all of the patches as stated earlier.
be sure there is no old bdwrite binary in PATH? PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin
FFMPEG::open_decoder: some stream times estimated: /root/media/hockey.ts Render::render_single: Session finished. ** rendered 679 frames in 15.393 secs, 44.111 fps ++ dirname /tmp/bd_20220417-102756/bd.sh + sdir=/tmp/bd_20220417-102756 ++ cd /tmp/bd_20220417-102756 ++ pwd + dir=/tmp/bd_20220417-102756 + PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/ local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin + mkdir -p /tmp/bd_20220417-102756/udfs ++ tail -1 ++ du -cb /tmp/bd_20220417-102756/bd.m2ts ++ sed -e 's/[ ].*//' + sz=40396800 + blks=23821 + rm -f /tmp/bd_20220417-102756/bd.udfs + '[' -f bd.meta ']' + mkudffs -b 2048 /tmp/bd_20220417-102756/bd.udfs 23821 filename=/tmp/bd_20220417-102756/bd.udfs label=LinuxUDF uuid=625c4025cebbb06e blocksize=2048 blocks=23821 udfrev=2.01 start=0, blocks=16, type=ERASE start=16, blocks=4, type=VRS ... start=23648, blocks=16, type=RVDS start=23664, blocks=156, type=ERASE start=23820, blocks=1, type=ANCHOR + mount -t udf -o loop /tmp/bd_20220417-102756/bd.udfs /tmp/bd_20220417-102756/udfs + bdwrite /tmp/bd_20220417-102756/udfs /tmp/bd_20220417-102756/bd.m2ts *unknown bluray audio format 0 ch*
FFMPEG::open_decoder: some stream times estimated: /root/media/hockey.ts Render::render_single: Session finished. ** rendered 679 frames in 15.329 secs, 44.295 fps ++ dirname /tmp/bd_20220417-105416/bd.sh + sdir=/tmp/bd_20220417-105416 ++ cd /tmp/bd_20220417-105416 ++ pwd + dir=/tmp/bd_20220417-105416 + PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/ local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin + mkdir -p /tmp/bd_20220417-105416/udfs ++ du -cb /tmp/bd_20220417-105416/bd.m2ts ++ tail -1 ++ sed -e 's/[ ].*//' + sz=44015616 + blks=25588 + rm -f /tmp/bd_20220417-105416/bd.udfs + '[' -f bd.meta ']' + mkudffs -b 2048 /tmp/bd_20220417-105416/bd.udfs 25588 filename=/tmp/bd_20220417-105416/bd.udfs label=LinuxUDF uuid=625c464fcd7855e8 blocksize=2048 blocks=25588 udfrev=2.01 start=0, blocks=16, type=ERASE start=16, blocks=4, type=VRS start=20, blocks=76, type=ERASE start=96, blocks=16, type=MVDS ... start=25587, blocks=1, type=ANCHOR + mount -t udf -o loop /tmp/bd_20220417-105416/bd.udfs /tmp/bd_20220417-105416/udfs + bdwrite /tmp/bd_20220417-105416/udfs /tmp/bd_20220417-105416/bd.m2ts *unknown bluray stream type pcm_bluray*
may be I misread code, but I thought they were set at fixed 5 min
intervals.. I thought making them at say 10 mins or even 15 mins from cmd line will be good idea.. apparently not (
No, it is a good idea, that is why I keep testing it because for a 2 hour movie which I might put on bluray, every 5 minutes is overkill for a chapter. But I will take your advice and move on for now. The biggest problem with the chapter patch is that on the bluray attached to the TV, when you move to the back to the previous chapter, it acts like it moves back but plays where you already were instead.
However, the choice of "tsmuxer" works, or at least does something and
creates no problem but I do not see or hear any difference if checked off or on.
you need to have tsmuxer binary in $PATH to see it used
I wonder why the output is different when I check the tsmuxer box than when I don't?
Because I do not check for tsmuxer existence in C code, and just write universal sh script doing check for us?
I do not have tsmuxer binary in the $PATH and when I do "whereis tsmuxer", I get nothing so I do not think it is installed. Also, when I play each of the blurary with and without tsmuxer checked, I don't really notice a difference but I have bad eyes (and ears).
this is good to know.. now try to install tsmuxer? :)? You can manually (or in qt5 gui) mark chapters there and see how players behave....
The 2 modifications I made are in bdcreate.C to temporarily comment out the
choices of lpcm and truehd as neither 1 works for me (see error messages in previous email).
those mesages come from players themselves?
No, from bdwrite -- see the last line in the terminal output below for the error message when I choose "truehd" and then "lpcm". I verified that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is in as well as all of the patches as stated earlier.
be sure there is no old bdwrite binary in PATH?
It is rare that I change $PATH from or even add cnelerra: /root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin
PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin
However, the choice of "tsmuxer" works, or at least does something and
creates no problem but I do not see or hear any difference if checked off or on.
you need to have tsmuxer binary in $PATH to see it used
I wonder why the output is different when I check the tsmuxer box than when I don't?
Because I do not check for tsmuxer existence in C code, and just write universal sh script doing check for us?
Never mind -- it is different just when running it twice so there must be timestamps in it. I did download tsmuxer source code, but when it said I needed "ninja", I stopped and just laughed. Maybe later I will try again.
On Sunday, April 17, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
The 2 modifications I made are in bdcreate.C to temporarily comment out
the choices of lpcm and truehd as neither 1 works for me (see error messages in previous email).
those mesages come from players themselves?
No, from bdwrite -- see the last line in the terminal output below for the error message when I choose "truehd" and then "lpcm". I verified that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is in as well as all of the patches as stated earlier.
be sure there is no old bdwrite binary in PATH?
It is rare that I change $PATH from or even add cnelerra: /root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin: /usr/sbin:/usr/bin
still, old bdwrite may lay here.. I say with some confidence because fully-patched bdwrite binary even output different error message for stream type! try to add some your own string ( fprintf ("my cool string\n";) into code of bdwrite (right into main {} function) and see if it printed when script executes?
PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/ local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin
However, the choice of "tsmuxer" works, or at least does something and
creates no problem but I do not see or hear any difference if checked off or on.
you need to have tsmuxer binary in $PATH to see it used
I wonder why the output is different when I check the tsmuxer box than when I don't?
Because I do not check for tsmuxer existence in C code, and just write universal sh script doing check for us?
Never mind -- it is different just when running it twice so there must be timestamps in it. I did download tsmuxer source code, but when it said I needed "ninja", I stopped and just laughed. Maybe later I will try again.
yeah, I have this installed for mesa3d builds mostly...
Andrew, Tomorrow I am going to make one last test (still without chapters) and check this mini_pile into GIT, but 1 more question.
From megapile_10, 0015-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch, I think the case renumbering of 3 and 4 may be incorrect. Currently the code for case 3 and 4 is different than what it used to be -- I think these numbers mean something (although 0x03 versus 3 is OK and 0x04 versus 4 is OK). See this diff in bdwrite.C : *Before = * *After =* case 0x04: case 4: bs.write(subpath_id, 8); bs.write(subpath_id, 8); bs.write(subclip_id, 8); bs.write(pid, 16); bs.write(pid, 16); break; break;
case 0x03: case 3: bs.write(subpath_id, 8); bs.write(subpath_id, 8); bs.write(pid, 16); bs.write(subclip_id, 8); break; bs.write(pid, 16); break: Could you check this?? On Sun, Apr 17, 2022 at 12:01 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
On Sunday, April 17, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
The 2 modifications I made are in bdcreate.C to temporarily comment out
the choices of lpcm and truehd as neither 1 works for me (see error messages in previous email).
those mesages come from players themselves?
No, from bdwrite -- see the last line in the terminal output below for the error message when I choose "truehd" and then "lpcm". I verified that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is in as well as all of the patches as stated earlier.
be sure there is no old bdwrite binary in PATH?
It is rare that I change $PATH from or even add cnelerra: /root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin
still, old bdwrite may lay here.. I say with some confidence because fully-patched bdwrite binary even output different error message for stream type!
try to add some your own string ( fprintf ("my cool string\n";) into code of bdwrite (right into main {} function) and see if it printed when script executes?
PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin
However, the choice of "tsmuxer" works, or at least does something and
creates no problem but I do not see or hear any difference if checked off or on.
you need to have tsmuxer binary in $PATH to see it used
I wonder why the output is different when I check the tsmuxer box than when I don't?
Because I do not check for tsmuxer existence in C code, and just write universal sh script doing check for us?
Never mind -- it is different just when running it twice so there must be timestamps in it. I did download tsmuxer source code, but when it said I needed "ninja", I stopped and just laughed. Maybe later I will try again.
yeah, I have this installed for mesa3d builds mostly...
On Monday, April 18, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, Tomorrow I am going to make one last test (still without chapters) and check this mini_pile into GIT, but 1 more question. From megapile_10, 0015-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch, I think the case renumbering of 3 and 4 may be incorrect. Currently the code for case 3 and 4 is different than what it used to be -- I think these numbers mean something (although 0x03 versus 3 is OK and 0x04 versus 4 is OK).
strange, for me patch itself look different..... are you comparing to head (before any of my changes?)
See this diff in bdwrite.C : *Before = * *After =* case 0x04: case 4: bs.write(subpath_id, 8); bs.write(subpath_id, 8); bs.write(subclip_id, 8); bs.write(pid, 16); bs.write(pid, 16); break; break;
case 0x03: case 3: bs.write(subpath_id, 8); bs.write(subpath_id, 8); bs.write(pid, 16); bs.write(subclip_id, 8); break; bs.write(pid, 16); break:
Could you check this??
On Sun, Apr 17, 2022 at 12:01 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
On Sunday, April 17, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
The 2 modifications I made are in bdcreate.C to temporarily comment out
> the choices of lpcm and truehd as neither 1 works for me (see error > messages in previous email). >
those mesages come from players themselves?
No, from bdwrite -- see the last line in the terminal output below for the error message when I choose "truehd" and then "lpcm". I verified that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is in as well as all of the patches as stated earlier.
be sure there is no old bdwrite binary in PATH?
It is rare that I change $PATH from or even add cnelerra: /root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin: /usr/sbin:/usr/bin
still, old bdwrite may lay here.. I say with some confidence because fully-patched bdwrite binary even output different error message for stream type!
try to add some your own string ( fprintf ("my cool string\n";) into code of bdwrite (right into main {} function) and see if it printed when script executes?
PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/ local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin
However, the choice of "tsmuxer" works, or at least does something and
> creates no problem but I do not see or hear any difference if checked off > or on. > you need to have tsmuxer binary in $PATH to see it used
I wonder why the output is different when I check the tsmuxer box than when I don't?
Because I do not check for tsmuxer existence in C code, and just write universal sh script doing check for us?
Never mind -- it is different just when running it twice so there must be timestamps in it. I did download tsmuxer source code, but when it said I needed "ninja", I stopped and just laughed. Maybe later I will try again.
yeah, I have this installed for mesa3d builds mostly...
oh YES, you are right, I swapped those unintentionally! probably explains your bug with chapters? I used $ git diff 66e7bfbe cinelerra/bdwrite.C and yes, please switch cases 2/3 and 4 as they originally were... so it will look like this: @@ -1905,24 +1916,24 @@ write() bs.write(stream_type, 8); switch (stream_type) { - case 0x01: + case 1: bs.write(pid, 16); break; - case 0x02: - case 0x04: + case 2: + case 4: bs.write(subpath_id, 8); bs.write(subclip_id, 8); bs.write(pid, 16); break; - case 0x03: + case 3: bs.write(subpath_id, 8); bs.write(pid, 16); break; default: - fprintf(stderr, "unrecognized stream type %02x\n", stream_type); + fprintf(stderr, "unrecognized mpls stream type %02x\n", stream_type); break; }; bs.padb(9 - strm.bs_posb(bs)); @@ -1935,6 +1946,7 @@ write() case BLURAY_STREAM_TYPE_VIDEO_MPEG2: case BLURAY_STREAM_TYPE_VIDEO_VC1: === i can make real fix patch if you wish On Monday, April 18, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, Tomorrow I am going to make one last test (still without chapters) and check this mini_pile into GIT, but 1 more question. From megapile_10, 0015-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch, I think the case renumbering of 3 and 4 may be incorrect. Currently the code for case 3 and 4 is different than what it used to be -- I think these numbers mean something (although 0x03 versus 3 is OK and 0x04 versus 4 is OK). See this diff in bdwrite.C : *Before = * *After =* case 0x04: case 4: bs.write(subpath_id, 8); bs.write(subpath_id, 8); bs.write(subclip_id, 8); bs.write(pid, 16); bs.write(pid, 16); break; break;
case 0x03: case 3: bs.write(subpath_id, 8); bs.write(subpath_id, 8); bs.write(pid, 16); bs.write(subclip_id, 8); break; bs.write(pid, 16); break:
Could you check this??
On Sun, Apr 17, 2022 at 12:01 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
On Sunday, April 17, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
The 2 modifications I made are in bdcreate.C to temporarily comment out
> the choices of lpcm and truehd as neither 1 works for me (see error > messages in previous email). >
those mesages come from players themselves?
No, from bdwrite -- see the last line in the terminal output below for the error message when I choose "truehd" and then "lpcm". I verified that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is in as well as all of the patches as stated earlier.
be sure there is no old bdwrite binary in PATH?
It is rare that I change $PATH from or even add cnelerra: /root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin: /usr/sbin:/usr/bin
still, old bdwrite may lay here.. I say with some confidence because fully-patched bdwrite binary even output different error message for stream type!
try to add some your own string ( fprintf ("my cool string\n";) into code of bdwrite (right into main {} function) and see if it printed when script executes?
PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/ local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin
However, the choice of "tsmuxer" works, or at least does something and
> creates no problem but I do not see or hear any difference if checked off > or on. > you need to have tsmuxer binary in $PATH to see it used
I wonder why the output is different when I check the tsmuxer box than when I don't?
Because I do not check for tsmuxer existence in C code, and just write universal sh script doing check for us?
Never mind -- it is different just when running it twice so there must be timestamps in it. I did download tsmuxer source code, but when it said I needed "ninja", I stopped and just laughed. Maybe later I will try again.
yeah, I have this installed for mesa3d builds mostly...
I will fix it, do not need a patch (and will retest chapters again). On Sun, Apr 17, 2022 at 10:34 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
oh YES, you are right, I swapped those unintentionally!
probably explains your bug with chapters? I used
$ git diff 66e7bfbe cinelerra/bdwrite.C
and yes, please switch cases 2/3 and 4 as they originally were... so it will look like this:
@@ -1905,24 +1916,24 @@ write()
bs.write(stream_type, 8); switch (stream_type) { - case 0x01: + case 1: bs.write(pid, 16); break;
- case 0x02: - case 0x04: + case 2: + case 4: bs.write(subpath_id, 8); bs.write(subclip_id, 8); bs.write(pid, 16); break;
- case 0x03: + case 3: bs.write(subpath_id, 8); bs.write(pid, 16); break;
default: - fprintf(stderr, "unrecognized stream type %02x\n", stream_type); + fprintf(stderr, "unrecognized mpls stream type %02x\n", stream_type); break; }; bs.padb(9 - strm.bs_posb(bs)); @@ -1935,6 +1946,7 @@ write() case BLURAY_STREAM_TYPE_VIDEO_MPEG2: case BLURAY_STREAM_TYPE_VIDEO_VC1:
===
i can make real fix patch if you wish
On Monday, April 18, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, Tomorrow I am going to make one last test (still without chapters) and check this mini_pile into GIT, but 1 more question. From megapile_10, 0015-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch, I think the case renumbering of 3 and 4 may be incorrect. Currently the code for case 3 and 4 is different than what it used to be -- I think these numbers mean something (although 0x03 versus 3 is OK and 0x04 versus 4 is OK). See this diff in bdwrite.C : *Before = * *After =* case 0x04: case 4: bs.write(subpath_id, 8); bs.write(subpath_id, 8); bs.write(subclip_id, 8); bs.write(pid, 16); bs.write(pid, 16); break; break;
case 0x03: case 3: bs.write(subpath_id, 8); bs.write(subpath_id, 8); bs.write(pid, 16); bs.write(subclip_id, 8); break; bs.write(pid, 16); break:
Could you check this??
On Sun, Apr 17, 2022 at 12:01 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
On Sunday, April 17, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
The 2 modifications I made are in bdcreate.C to temporarily comment out
>> the choices of lpcm and truehd as neither 1 works for me (see error >> messages in previous email). >> > > those mesages come from players themselves? >
No, from bdwrite -- see the last line in the terminal output below for the error message when I choose "truehd" and then "lpcm". I verified that 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch is in as well as all of the patches as stated earlier.
be sure there is no old bdwrite binary in PATH?
It is rare that I change $PATH from or even add cnelerra: /root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin
still, old bdwrite may lay here.. I say with some confidence because fully-patched bdwrite binary even output different error message for stream type!
try to add some your own string ( fprintf ("my cool string\n";) into code of bdwrite (right into main {} function) and see if it printed when script executes?
PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/tmp/cinelerra-5.1/bin
However, the choice of "tsmuxer" works, or at least does something and
>> creates no problem but I do not see or hear any difference if checked off >> or on. >> > you need to have tsmuxer binary in $PATH to see it used > I wonder why the output is different when I check the tsmuxer box than when I don't?
Because I do not check for tsmuxer existence in C code, and just write universal sh script doing check for us?
Never mind -- it is different just when running it twice so there must be timestamps in it. I did download tsmuxer source code, but when it said I needed "ninja", I stopped and just laughed. Maybe later I will try again.
yeah, I have this installed for mesa3d builds mostly...
Checked into GIT from megapile_8 the patches related to creating Bluray media by Andrew: 0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch 0007-EXPERIMENTAL-add-bd_profile-array-to-bdcreate.C-so-i.patch 0008-EXPERIMENTAL-bdcreate-add-m2ts-profiles-part-1.patch 0009-Fix-bdcreate.C-layout.patch 0010-EXPERIMENTAL-attempt-to-get-value-from-popuptextbox.patch0012-truehd-experimental-bluray-profile.patch 0013-EXPERIMENTAL-add-truehd-audio-profile-for-bdcreate.C.patch 0014-EXPERIMENTAL-add-tsmuxer-checkbox.patch 0015-EXPERIMENTAL-fix-layout-in-bdcreate-after-tsmuxer-ch.patch 0016-NOT-YET.patch 0017-EXPERIMENTAL-shell-script-run-tsmuxer-conditionally-.patch 0018-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch 0019-EXPERIMENTAL-attempt-at-fixing-bdwrite-on-Android-af.patch 0020-EXPERIMENTAL-real-fix-for-bdwrite.patch 0021-EXPERIMENTAL-try-to-add-lpcm-to-tsmuxer-meta-file.patch 0022-EXPERIMENTAL-really-fix-audio-names-fir-tsmuxer-meta.patch 0037-freebsd-in-bdcreate-bdwrite.patch and from megapile_10: 0077-Better-layout-in-bdcreate.C-after-my-changes.patch Already in from a previous checkin as related to Bluray from megapile_8 were: 0001-ffmpeg-4.4-bluray-lpcm-encoder.patch 0002-Fix-ffmpeg-4.4-bluray-lpcm-patch-for-5.1.patch 0003-Add-simple-m2ts-lpcm-profile.patch 0011-Rename-m2ts_pcm.m2ts-to-bluray_lpcm.m2ts.patch But because I forgot to test 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch the choice in bdcreate.C for truehd (line 865) was commented out until I can test a smaller set tomorrow. Although *I am confused why the following lines of code (around line 70) in bdcreate.C do not include truehd as an option???* I looked in megapile_10 to see if I missed a related patch but did not see anything. static struct bd_profile { const char *name; } bd_profiles[] = { {"bluray.m2ts"}, {"bluray_lpcm.m2ts"}, }; and around line 350 (and maybe other places too?): fprintf(fp,"MUXOPT --blu-ray --hdmv-descriptors\n"); fprintf(fp,"V_MPEG4/ISO/AVC, bd.m2ts, track=4113\n"); if(!strcmp(use_profile, "bluray.m2ts")) fprintf(fp,"A_AC3, bd.m2ts, track=4352\n"); if(!strcmp(use_profile, "bluray_lpcm.m2ts")) fprintf(fp,"A_LPCM, bd.m2ts, track=4352\n"); fprintf(fp,"\n"); fclose(fp); oh YES, you are right, I swapped those unintentionally!
probably explains your bug with chapters?
YOU ARE RIGHT ! now chapters work (hopefully you understand why it takes me so long to test and check in changes as I do not want to add problems -- the oxen is slow, but the earth is patient). "lpcm" works too and when I press the "info" button on the remote control on the LG bluray player, it clearly shows it is lpcm -- this not working was my mistake due to not getting the current GIT head.
Forgot to add that this patch also applied and result checked in even though not yet functional: 0012-truehd-experimental-bluray-profile.patch On Mon, Apr 18, 2022 at 6:21 PM Phyllis Smith <phylsmith2017@gmail.com> wrote:
Checked into GIT from megapile_8 the patches related to creating Bluray media by Andrew:
0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch 0007-EXPERIMENTAL-add-bd_profile-array-to-bdcreate.C-so-i.patch 0008-EXPERIMENTAL-bdcreate-add-m2ts-profiles-part-1.patch 0009-Fix-bdcreate.C-layout.patch
0010-EXPERIMENTAL-attempt-to-get-value-from-popuptextbox.patch0012-truehd-experimental-bluray-profile.patch 0013-EXPERIMENTAL-add-truehd-audio-profile-for-bdcreate.C.patch 0014-EXPERIMENTAL-add-tsmuxer-checkbox.patch 0015-EXPERIMENTAL-fix-layout-in-bdcreate-after-tsmuxer-ch.patch 0016-NOT-YET.patch 0017-EXPERIMENTAL-shell-script-run-tsmuxer-conditionally-.patch 0018-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch 0019-EXPERIMENTAL-attempt-at-fixing-bdwrite-on-Android-af.patch 0020-EXPERIMENTAL-real-fix-for-bdwrite.patch 0021-EXPERIMENTAL-try-to-add-lpcm-to-tsmuxer-meta-file.patch 0022-EXPERIMENTAL-really-fix-audio-names-fir-tsmuxer-meta.patch 0037-freebsd-in-bdcreate-bdwrite.patch and from megapile_10: 0077-Better-layout-in-bdcreate.C-after-my-changes.patch
Already in from a previous checkin as related to Bluray from megapile_8 were: 0001-ffmpeg-4.4-bluray-lpcm-encoder.patch 0002-Fix-ffmpeg-4.4-bluray-lpcm-patch-for-5.1.patch 0003-Add-simple-m2ts-lpcm-profile.patch 0011-Rename-m2ts_pcm.m2ts-to-bluray_lpcm.m2ts.patch But because I forgot to test 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch the choice in bdcreate.C for truehd (line 865) was commented out until I can test a smaller set tomorrow. Although *I am confused why the following lines of code (around line 70) in bdcreate.C do not include truehd as an option???* I looked in megapile_10 to see if I missed a related patch but did not see anything. static struct bd_profile { const char *name; } bd_profiles[] = { {"bluray.m2ts"}, {"bluray_lpcm.m2ts"}, };
and around line 350 (and maybe other places too?): fprintf(fp,"MUXOPT --blu-ray --hdmv-descriptors\n"); fprintf(fp,"V_MPEG4/ISO/AVC, bd.m2ts, track=4113\n"); if(!strcmp(use_profile, "bluray.m2ts")) fprintf(fp,"A_AC3, bd.m2ts, track=4352\n"); if(!strcmp(use_profile, "bluray_lpcm.m2ts")) fprintf(fp,"A_LPCM, bd.m2ts, track=4352\n"); fprintf(fp,"\n"); fclose(fp);
oh YES, you are right, I swapped those unintentionally!
probably explains your bug with chapters?
YOU ARE RIGHT ! now chapters work (hopefully you understand why it takes me so long to test and check in changes as I do not want to add problems -- the oxen is slow, but the earth is patient).
"lpcm" works too and when I press the "info" button on the remote control on the LG bluray player, it clearly shows it is lpcm -- this not working was my mistake due to not getting the current GIT head.
On Tuesday, April 19, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Forgot to add that this patch also applied and result checked in even though not yet functional: 0012-truehd-experimental-bluray-profile.patch
On Mon, Apr 18, 2022 at 6:21 PM Phyllis Smith <phylsmith2017@gmail.com> wrote:
Checked into GIT from megapile_8 the patches related to creating Bluray media by Andrew:
0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch 0007-EXPERIMENTAL-add-bd_profile-array-to-bdcreate.C-so-i.patch 0008-EXPERIMENTAL-bdcreate-add-m2ts-profiles-part-1.patch 0009-Fix-bdcreate.C-layout.patch 0010-EXPERIMENTAL-attempt-to-get-value-from-popuptextbox. patch0012-truehd-experimental-bluray-profile.patch 0013-EXPERIMENTAL-add-truehd-audio-profile-for-bdcreate.C.patch 0014-EXPERIMENTAL-add-tsmuxer-checkbox.patch 0015-EXPERIMENTAL-fix-layout-in-bdcreate-after-tsmuxer-ch.patch 0016-NOT-YET.patch 0017-EXPERIMENTAL-shell-script-run-tsmuxer-conditionally-.patch 0018-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch 0019-EXPERIMENTAL-attempt-at-fixing-bdwrite-on-Android-af.patch 0020-EXPERIMENTAL-real-fix-for-bdwrite.patch 0021-EXPERIMENTAL-try-to-add-lpcm-to-tsmuxer-meta-file.patch 0022-EXPERIMENTAL-really-fix-audio-names-fir-tsmuxer-meta.patch 0037-freebsd-in-bdcreate-bdwrite.patch and from megapile_10: 0077-Better-layout-in-bdcreate.C-after-my-changes.patch
Already in from a previous checkin as related to Bluray from megapile_8 were: 0001-ffmpeg-4.4-bluray-lpcm-encoder.patch 0002-Fix-ffmpeg-4.4-bluray-lpcm-patch-for-5.1.patch 0003-Add-simple-m2ts-lpcm-profile.patch 0011-Rename-m2ts_pcm.m2ts-to-bluray_lpcm.m2ts.patch But because I forgot to test 0004-Improve-truehd-decoder- encoder-from-ffmpeg.git.patch the choice in bdcreate.C for truehd (line 865) was commented out until I can test a smaller set tomorrow. Although *I am confused why the following lines of code (around line 70) in bdcreate.C do not include truehd as an option???* I looked in megapile_10 to see if I missed a related patch but did not see anything. static struct bd_profile { const char *name; } bd_profiles[] = { {"bluray.m2ts"}, {"bluray_lpcm.m2ts"}, };
I think I just did things a little bit different, so may be this piece if code no longer needed - need to look again (just wake up)
and around line 350 (and maybe other places too?): fprintf(fp,"MUXOPT --blu-ray --hdmv-descriptors\n"); fprintf(fp,"V_MPEG4/ISO/AVC, bd.m2ts, track=4113\n"); if(!strcmp(use_profile, "bluray.m2ts")) fprintf(fp,"A_AC3, bd.m2ts, track=4352\n"); if(!strcmp(use_profile, "bluray_lpcm.m2ts")) fprintf(fp,"A_LPCM, bd.m2ts, track=4352\n"); fprintf(fp,"\n"); fclose(fp);
yes, not yet for tsmuxer - not quite sure how it works there (latery I read truehd must come with ac3 'core' embedded, not sure if ffmpeg can output this in one pass? - https://forum.doom9.org/showthread.php?t=176668&page=61 - comment 1202 and around...) it will be very interesting to hear from your experiment!
oh YES, you are right, I swapped those unintentionally!
probably explains your bug with chapters?
YOU ARE RIGHT ! now chapters work (hopefully you understand why it takes me so long to test and check in changes as I do not want to add problems -- the oxen is slow, but the earth is patient).
yes, very big thanks for NOT rushing things out!
"lpcm" works too and when I press the "info" button on the remote control on the LG bluray player, it clearly shows it is lpcm -- this not working was my mistake due to not getting the current GIT head.
\0/
For Truehd, in bdwrite.C getting error message as shown in second Bold below when 004 ffmpeg truehd new 4 patches added. In addition it shows "case 2" as STEREO although earlier in the code it is "3" as shown immediately below (and COMBO 12 not handled). BLURAY_AUDIO_FORMAT_MONO = 1, *BLURAY_AUDIO_FORMAT_STEREO = 3,* BLURAY_AUDIO_FORMAT_MULTI_CHAN = 6, BLURAY_AUDIO_FORMAT_COMBO = 12, // Stereo ac3/dts, ... static int bd_audio_format(int channels) { int audio_format = 0; switch( channels ) { case 1: audio_format = BLURAY_AUDIO_FORMAT_MONO; break; case 2: audio_format = BLURAY_AUDIO_FORMAT_STEREO; break; case 6: audio_format = BLURAY_AUDIO_FORMAT_MULTI_CHAN; break; default: fprintf(stderr, *"unknown bluray audio format %d ch\n", channels*); exit(1); } return audio_format; } On Mon, Apr 18, 2022 at 10:33 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
On Tuesday, April 19, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Forgot to add that this patch also applied and result checked in even though not yet functional: 0012-truehd-experimental-bluray-profile.patch
On Mon, Apr 18, 2022 at 6:21 PM Phyllis Smith <phylsmith2017@gmail.com> wrote:
Checked into GIT from megapile_8 the patches related to creating Bluray media by Andrew:
0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch 0007-EXPERIMENTAL-add-bd_profile-array-to-bdcreate.C-so-i.patch 0008-EXPERIMENTAL-bdcreate-add-m2ts-profiles-part-1.patch 0009-Fix-bdcreate.C-layout.patch
0010-EXPERIMENTAL-attempt-to-get-value-from-popuptextbox.patch0012-truehd-experimental-bluray-profile.patch 0013-EXPERIMENTAL-add-truehd-audio-profile-for-bdcreate.C.patch 0014-EXPERIMENTAL-add-tsmuxer-checkbox.patch 0015-EXPERIMENTAL-fix-layout-in-bdcreate-after-tsmuxer-ch.patch 0016-NOT-YET.patch 0017-EXPERIMENTAL-shell-script-run-tsmuxer-conditionally-.patch 0018-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch 0019-EXPERIMENTAL-attempt-at-fixing-bdwrite-on-Android-af.patch 0020-EXPERIMENTAL-real-fix-for-bdwrite.patch 0021-EXPERIMENTAL-try-to-add-lpcm-to-tsmuxer-meta-file.patch 0022-EXPERIMENTAL-really-fix-audio-names-fir-tsmuxer-meta.patch 0037-freebsd-in-bdcreate-bdwrite.patch and from megapile_10: 0077-Better-layout-in-bdcreate.C-after-my-changes.patch
Already in from a previous checkin as related to Bluray from megapile_8 were: 0001-ffmpeg-4.4-bluray-lpcm-encoder.patch 0002-Fix-ffmpeg-4.4-bluray-lpcm-patch-for-5.1.patch 0003-Add-simple-m2ts-lpcm-profile.patch 0011-Rename-m2ts_pcm.m2ts-to-bluray_lpcm.m2ts.patch But because I forgot to test 0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch the choice in bdcreate.C for truehd (line 865) was commented out until I can test a smaller set tomorrow. Although *I am confused why the following lines of code (around line 70) in bdcreate.C do not include truehd as an option???* I looked in megapile_10 to see if I missed a related patch but did not see anything. static struct bd_profile { const char *name; } bd_profiles[] = { {"bluray.m2ts"}, {"bluray_lpcm.m2ts"}, };
I think I just did things a little bit different, so may be this piece if code no longer needed - need to look again (just wake up)
and around line 350 (and maybe other places too?): fprintf(fp,"MUXOPT --blu-ray --hdmv-descriptors\n"); fprintf(fp,"V_MPEG4/ISO/AVC, bd.m2ts, track=4113\n"); if(!strcmp(use_profile, "bluray.m2ts")) fprintf(fp,"A_AC3, bd.m2ts, track=4352\n"); if(!strcmp(use_profile, "bluray_lpcm.m2ts")) fprintf(fp,"A_LPCM, bd.m2ts, track=4352\n"); fprintf(fp,"\n"); fclose(fp);
yes, not yet for tsmuxer - not quite sure how it works there (latery I read truehd must come with ac3 'core' embedded, not sure if ffmpeg can output this in one pass? - https://forum.doom9.org/showthread.php?t=176668&page=61 - comment 1202 and around...)
it will be very interesting to hear from your experiment!
oh YES, you are right, I swapped those unintentionally!
probably explains your bug with chapters?
YOU ARE RIGHT ! now chapters work (hopefully you understand why it takes me so long to test and check in changes as I do not want to add problems -- the oxen is slow, but the earth is patient).
yes, very big thanks for NOT rushing things out!
"lpcm" works too and when I press the "info" button on the remote control on the LG bluray player, it clearly shows it is lpcm -- this not working was my mistake due to not getting the current GIT head.
\0/
well, case 2 is for usual 2.0 stereo (two channels) .. but it has identifier symbolically defined as bluray_audio_format_stereo and value of this constant is '3' .... so, for truehd you were getting 12 'channels' for usual 5.1 sound? so this check failed..? On Tuesday, April 19, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
For Truehd, in bdwrite.C getting error message as shown in second Bold below when 004 ffmpeg truehd new 4 patches added. In addition it shows "case 2" as STEREO although earlier in the code it is "3" as shown immediately below (and COMBO 12 not handled).
BLURAY_AUDIO_FORMAT_MONO = 1, *BLURAY_AUDIO_FORMAT_STEREO = 3,* BLURAY_AUDIO_FORMAT_MULTI_CHAN = 6, BLURAY_AUDIO_FORMAT_COMBO = 12, // Stereo ac3/dts, ... static int bd_audio_format(int channels) { int audio_format = 0; switch( channels ) { case 1: audio_format = BLURAY_AUDIO_FORMAT_MONO; break; case 2: audio_format = BLURAY_AUDIO_FORMAT_STEREO; break; case 6: audio_format = BLURAY_AUDIO_FORMAT_MULTI_CHAN; break; default: fprintf(stderr, *"unknown bluray audio format %d ch\n", channels*); exit(1); } return audio_format; }
On Mon, Apr 18, 2022 at 10:33 PM Andrew Randrianasulu < randrianasulu@gmail.com> wrote:
On Tuesday, April 19, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Forgot to add that this patch also applied and result checked in even though not yet functional: 0012-truehd-experimental-bluray-profile.patch
On Mon, Apr 18, 2022 at 6:21 PM Phyllis Smith <phylsmith2017@gmail.com> wrote:
Checked into GIT from megapile_8 the patches related to creating Bluray media by Andrew:
0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch 0007-EXPERIMENTAL-add-bd_profile-array-to-bdcreate.C-so-i.patch 0008-EXPERIMENTAL-bdcreate-add-m2ts-profiles-part-1.patch 0009-Fix-bdcreate.C-layout.patch 0010-EXPERIMENTAL-attempt-to-get-value-from-popuptextbox. patch0012-truehd-experimental-bluray-profile.patch 0013-EXPERIMENTAL-add-truehd-audio-profile-for-bdcreate.C.patch 0014-EXPERIMENTAL-add-tsmuxer-checkbox.patch 0015-EXPERIMENTAL-fix-layout-in-bdcreate-after-tsmuxer-ch.patch 0016-NOT-YET.patch 0017-EXPERIMENTAL-shell-script-run-tsmuxer-conditionally-.patch 0018-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch 0019-EXPERIMENTAL-attempt-at-fixing-bdwrite-on-Android-af.patch 0020-EXPERIMENTAL-real-fix-for-bdwrite.patch 0021-EXPERIMENTAL-try-to-add-lpcm-to-tsmuxer-meta-file.patch 0022-EXPERIMENTAL-really-fix-audio-names-fir-tsmuxer-meta.patch 0037-freebsd-in-bdcreate-bdwrite.patch and from megapile_10: 0077-Better-layout-in-bdcreate.C-after-my-changes.patch
Already in from a previous checkin as related to Bluray from megapile_8 were: 0001-ffmpeg-4.4-bluray-lpcm-encoder.patch 0002-Fix-ffmpeg-4.4-bluray-lpcm-patch-for-5.1.patch 0003-Add-simple-m2ts-lpcm-profile.patch 0011-Rename-m2ts_pcm.m2ts-to-bluray_lpcm.m2ts.patch But because I forgot to test 0004-Improve-truehd-decoder- encoder-from-ffmpeg.git.patch the choice in bdcreate.C for truehd (line 865) was commented out until I can test a smaller set tomorrow. Although *I am confused why the following lines of code (around line 70) in bdcreate.C do not include truehd as an option???* I looked in megapile_10 to see if I missed a related patch but did not see anything. static struct bd_profile { const char *name; } bd_profiles[] = { {"bluray.m2ts"}, {"bluray_lpcm.m2ts"}, };
I think I just did things a little bit different, so may be this piece if code no longer needed - need to look again (just wake up)
and around line 350 (and maybe other places too?): fprintf(fp,"MUXOPT --blu-ray --hdmv-descriptors\n"); fprintf(fp,"V_MPEG4/ISO/AVC, bd.m2ts, track=4113\n"); if(!strcmp(use_profile, "bluray.m2ts")) fprintf(fp,"A_AC3, bd.m2ts, track=4352\n"); if(!strcmp(use_profile, "bluray_lpcm.m2ts")) fprintf(fp,"A_LPCM, bd.m2ts, track=4352\n"); fprintf(fp,"\n"); fclose(fp);
yes, not yet for tsmuxer - not quite sure how it works there (latery I read truehd must come with ac3 'core' embedded, not sure if ffmpeg can output this in one pass? - https://forum.doom9.org/ showthread.php?t=176668&page=61 - comment 1202 and around...)
it will be very interesting to hear from your experiment!
oh YES, you are right, I swapped those unintentionally!
probably explains your bug with chapters?
YOU ARE RIGHT ! now chapters work (hopefully you understand why it takes me so long to test and check in changes as I do not want to add problems -- the oxen is slow, but the earth is patient).
yes, very big thanks for NOT rushing things out!
"lpcm" works too and when I press the "info" button on the remote control on the LG bluray player, it clearly shows it is lpcm -- this not working was my mistake due to not getting the current GIT head.
\0/
participants (3)
-
Andrea paz -
Andrew Randrianasulu -
Phyllis Smith