On Saturday, April 16, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, another Bluray update. From megapile_8, I have in the following Bluray patches with 2 modifications and the bluray disc works on both the Samsung UHD and the LG Bluray connected to the TV.
0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc. patch0007-EXPERIMENTAL-add-bd_profile-array-to-bdcreate.C-so-i.patch 0008-EXPERIMENTAL-bdcreate-add-m2ts-profiles-part-1.patch 0009-Fix-bdcreate.C-layout.patch 0010-EXPERIMENTAL-attempt-to-get-value-from-popuptextbox.patch 0012-truehd-experimental-bluray-profile.patch 0013-EXPERIMENTAL-add-truehd-audio-profile-for-bdcreate.C.patch 0014-EXPERIMENTAL-add-tsmuxer-checkbox.patch 0015-EXPERIMENTAL-fix-layout-in-bdcreate-after-tsmuxer-ch.patch 0016-NOT-YET.patch 0017-EXPERIMENTAL-shell-script-run-tsmuxer-conditionally-.patch 0018-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch 0019-EXPERIMENTAL-attempt-at-fixing-bdwrite-on-Android-af.patch 0020-EXPERIMENTAL-real-fix-for-bdwrite.patch 0021-EXPERIMENTAL-try-to-add-lpcm-to-tsmuxer-meta-file.patch 0022-EXPERIMENTAL-really-fix-audio-names-fir-tsmuxer-meta.patch 0037-freebsd-in-bdcreate-bdwrite.patch
(0001-0004 and 0011 were already checked into GIT)
Unfortunately 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch causes problems BUT there are already chapters being written so I do not know why this was even added?
may be I misread code, but I thought they were set at fixed 5 min intervals.. I thought making them at say 10 mins or even 15 mins from cmd line will be good idea.. apparently not (
and probably that is why it does not work. SEE ATTACHED for current TV shot of current bluray and note the Info stating chapters and they work when I skip forward or backward to the next or previous chapter.
The 2 modifications I made are in bdcreate.C to temporarily comment out the choices of lpcm and truehd as neither 1 works for me (see error messages in previous email).
those mesages come from players themselves? check if they actually support those - they are optional... However, the choice of "tsmuxer" works, or at least does something and
creates no problem but I do not see or hear any difference if checked off or on.
you need to have tsmuxer binary in $PATH to see it used
On Wed, Apr 13, 2022 at 6:42 PM Phyllis Smith <phylsmith2017@gmail.com> wrote:
Andrew, just an update only. I want to continue with the Bluray patches despite the problem with 0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch which I had to back out. So I went forward with 0007-0017 which correctly patched but neither the choice of bluray_lpcm.m2ts or bluray_truehd.m2ts worked (got unknown bluray stream pcm_bluray and got unknown bluray audio format 0 ch). You may very well have fixed these in later patches but I am trying to go in order. Then as I patch 0018 and 0019, hunks fail because there is no "every_n_sec" from 0006-EXPERIMENTAL-add- variable-chapter-interval-to-bdwrit.patch was backed out.
No need to reply -- I will continue to work around this and make changes manually so I can see if I can get the tsmuxer muxing and selectable audio codec working because they would be good additions.
from a previous disc write (it is a Rewritable Disc because I have to test over and over and over again when it comes to bluray).
I did look at all other patches that affect bdwrite.C in megapile_8 but see none that could possibly fix the chapter interval. These are 0016, 0018, 0019, 0020, 0037, 0046, 0052, and 0056. Should I ignore all EXPERIMENTAL patches for bluray?
well, other patches still add tsmuxer muxing and selectable audio codec - but if you have trouble playing disks created even with full patch set - set it aside...